ui: use metric name as custom chart title #81182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
I need to fix some whitespace but other than that, this works. |
dhartunian
approved these changes
May 13, 2022
pkg/ui/workspaces/db-console/src/views/reports/containers/customChart/index.tsx
Outdated
Show resolved
Hide resolved
erikgrinaker
approved these changes
May 13, 2022
Custom charts were previously difficult to read because the graph didn't include any indication of what was being graphed. This is now rectified by printing the metrics name. This isn't the most user friendly thing (ideally we would also include the actual title, and make the help text available) but with my limited TSX knowledge this is solving 90% of the problem with a 61 character change. Related to cockroachdb#81035. Release note: None
|
bors r=dhartunian,erikgrinaker It's beautiful:
|
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed: |
I think this has been fixed now since bors has managed to merge something in the meantime. Here goes... bors r=dhartunian,erikgrinaker |
|
Build failed: |
|
#73980 |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom charts were previously difficult to read because the graph didn't
include any indication of what was being graphed. This is now rectified
by printing the metrics name. This isn't the most user friendly thing
(ideally we would also include the actual title, and make the help text
available) but with my limited TSX knowledge this is solving 90% of the
problem with a 61 character change.
Related to #81035.
Release note: None