-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: update dates to 24h UTC #81077
ui: update dates to 24h UTC #81077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking if the AM/PM should also be removed here? https://github.com/cockroachdb/cockroach/blob/master/pkg/ui/workspaces/cluster-ui/src/statementsTable/statementsTableContent.tsx#L131
Reviewable status: complete! 1 of 0 LGTMs obtained
9bfcb9a
to
1c1fdc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice catch! Fixed!
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale)
This commit updates all dates to use a 24h format in UTC Fixes cockroachdb#78442 Fixes cockroachdb#80103 Release note (ui change): Update all dates to use 24h format in UTC
bors r+ |
Build succeeded: |
blathers backport release-22.1 |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 8027298 to blathers/backport-release-22.1-81077: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch release-22.1 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
This commit updates all dates to use a 24h format in UTC
Fixes #78442
Fixes #80103
Release note (ui change): Update all dates to use 24h format in UTC