Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: update dates to 24h UTC #81077

Merged
merged 1 commit into from
May 17, 2022
Merged

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented May 5, 2022

This commit updates all dates to use a 24h format in UTC

Fixes #78442
Fixes #80103

Release note (ui change): Update all dates to use 24h format in UTC

@maryliag maryliag requested a review from a team May 5, 2022 22:28
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@jocrl jocrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking if the AM/PM should also be removed here? https://github.com/cockroachdb/cockroach/blob/master/pkg/ui/workspaces/cluster-ui/src/statementsTable/statementsTableContent.tsx#L131

image.png

Otherwise, :lgtm: !

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@maryliag maryliag force-pushed the date-format-utc branch 2 times, most recently from 9bfcb9a to 1c1fdc3 Compare May 13, 2022 18:32
Copy link
Contributor Author

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice catch! Fixed!

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale)

Copy link
Contributor

@jocrl jocrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale)

This commit updates all dates to use a 24h format in UTC

Fixes cockroachdb#78442
Fixes cockroachdb#80103

Release note (ui change): Update all dates to use 24h format in UTC
@maryliag
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented May 17, 2022

Build succeeded:

@craig craig bot merged commit 9e64c79 into cockroachdb:master May 17, 2022
@maryliag
Copy link
Contributor Author

blathers backport release-22.1

@blathers-crl
Copy link

blathers-crl bot commented May 17, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 8027298 to blathers/backport-release-22.1-81077: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch release-22.1 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in label for diagnostic download menu Update time picker to 24h instead of 12h
3 participants