Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutils/buildutil: add disallowed_prefixes to disallowed_imports_test #80650

Merged

Conversation

ajwerner
Copy link
Contributor

@ajwerner ajwerner commented Apr 27, 2022

This is useful if you want to make sure that some part of the tree doesn't
depend (transitively) on any other part of the tree.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rickystewart rickystewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you need to dev generate bazel

@ajwerner
Copy link
Contributor Author

I removed the new test, I'll add it in the next PR.

This is useful if you want to make sure that some part of the tree doesn't
depend (transitively) on any other part of the tree. I also add a rule that
would have failed before cockroachdb#80638 merged.

Release note: None
@ajwerner ajwerner force-pushed the ajwerner/disallowed_import_prefixes branch from 5bd30b8 to ae48aee Compare April 27, 2022 18:42
@ajwerner
Copy link
Contributor Author

TFTR

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 27, 2022

Build succeeded:

@craig craig bot merged commit 0782bef into cockroachdb:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants