kvserver: introduce methods on raftRecvQueue{,s}
#80640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This removes ad-hoc `sync.Map`-ish code from the various callers. This commit also gives `raftRecvQueue` (note: no `s`) methods which are now used instead of directly reaching into the struct. Together this paves the way for tracking the size of the raft receive queue. Since the `sync.Map` synchronization is very loose, before this commit it was difficult to avoid leaking memory when queues were dropped and accessed concurrently. And similarly, reaching directly into individual queues will make it difficult to get things right. Now there's more synchronization around dropping queues and correct tracking of the sizes (& making sure there aren't leaks) is more straightforward. (The actual tracking will be added in a follow-up). Release note: None
erikgrinaker
approved these changes
Apr 28, 2022
|
CI failure is probably not mine, #80696 |
|
bors r=erikgrinaker |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes ad-hoc
sync.Map-ish code from the various callers.This commit also gives
raftRecvQueue(note: nos) methods whichare now used instead of directly reaching into the struct.
Together this paves the way for tracking the size of the raft receive
queue. Since the
sync.Mapsynchronization is very loose, before thiscommit it was difficult to avoid leaking memory when queues were dropped
and accessed concurrently. And similarly, reaching directly into
individual queues will make it difficult to get things right.
Now there's more synchronization around dropping queues and correct
tracking of the sizes (& making sure there aren't leaks) is more
straightforward. (The actual tracking will be added in a follow-up).
Release note: None