(WIP) ui: display closed sessions, add username and session status filter #80268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 20, 2022 13:57
This is the second phase of #67888 which is to expose closed sessions to the ListSessions endpoint. Previously, the ListSessions endpoint only returned open sessions. This change builds on top of the previous PR to add the `ClosedSessionsCache` and now allows the ListSessions endpoint to also return closed sessions in its response. The `ListSessionsRequest` object was edited to include a flag `exclude_closed_sessions` which is a boolean to exclude closed sessions. If unspecified, defaults to false and closed sessions are included in the response. Additionally, the `serverpb.Session` object was updated to include new `end` and `status` fields which specify the time the session ended and the status (active, idle, closed) of the session, respectively. Release note (api change): `ListSessions` now returns closed sessions in addition to open sessions; `ListSessionsRequest` now has a `exclude_closed_sessions` flag; `serverpb.Session` now has `end` and `status` fields.
Fixes #67888, #79914. Previously, the sessions page UI did not support displaying closed sessions and did not support the ability to filter by username or session status. This commit adds the "Closed" session status to closed sessions and adds the ability to filter by username and session status. Release note (ui change): sessions overview and session details pages now display closed sessions; sessions overview page now has username and session status filters.
|
This change is |
gtr
changed the title
|
Moved to #80410. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67888, #79914.
Previously, the sessions page UI did not support displaying closed
sessions and did not support the ability to filter by username or
session status. This commit adds the "Closed" session status to closed
sessions and adds the ability to filter by username and session status.
Release note (ui change): sessions overview and session details pages now
display closed sessions; sessions overview page now has username and session
status filters.