ui: move shared graph components to cluster-ui #80197
Conversation
|
This change is |
xinhaoz
force-pushed
the
common-chart-utils
branch
2 times, most recently
from
eeacd4b to
846fd0c
Compare
There was a problem hiding this comment.
Reviewed 5 of 11 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @maryliag)
There was a problem hiding this comment.
Small nit, otherwise 
Reviewable status:
pkg/ui/workspaces/cluster-ui/src/graphs/visualization/index.tsx, line 37 at r1 (raw file):
* as a title and a tooltip icon. */ export const Visualization: React.FC<VisualizationProps> = ({
Thanks for the clean up!
pkg/ui/workspaces/db-console/src/views/cluster/util/graphs.ts, line 31 at r1 (raw file):
MetricProps, QueryTimeInfo, } from "src/views/shared/components/metricQuery";
nit: Should the db console copy of AxisUnits be deleted, and have the existing usages import from cluster-ui?
xinhaoz
force-pushed
the
common-chart-utils
branch
from
846fd0c to
46757ab
Compare
|
pkg/ui/workspaces/db-console/src/views/cluster/util/graphs.ts, line 31 at r1 (raw file): Previously, jocrl (Josephine) wrote…
Done. |
|
pkg/ui/workspaces/db-console/src/views/cluster/util/graphs.ts, line 31 at r1 (raw file): Previously, xinhaoz (Xin Hao Zhang) wrote…
Mmm is this just me/reviewable, or does it seem like these changes weren't done/pushed? |
xinhaoz
force-pushed
the
common-chart-utils
branch
from
46757ab to
adabb97
Compare
|
pkg/ui/workspaces/db-console/src/views/cluster/util/graphs.ts, line 31 at r1 (raw file): Previously, jocrl (Josephine) wrote…
Oh my bad, didn't push. Done! |
There was a problem hiding this comment.
Thanks!
Reviewable status:
xinhaoz
force-pushed
the
common-chart-utils
branch
4 times, most recently
from
f6d9539 to
fdfff31
Compare
Part of cockroachdb#74516 This commit moves shared graph functions and components to cluster-ui package. This is to enable the new bar chart component to share axes utilities and containers with the older line graph component in db-console. Release note: None
xinhaoz
force-pushed
the
common-chart-utils
branch
from
fdfff31 to
b094c6c
Compare
|
TFTR! |
|
Build succeeded: |
Part of #74516
This commit moves shared graph functions and components to
cluster-ui package. This is to enable the new bar chart
component to share axes utilities and containers with
the older line graph component in db-console.
Release note: None