kvserver: downgrade spammy "skipping snapshot" message #80166
Conversation
|
This change is |
There was a problem hiding this comment.
🤦 I now realize that I used a local log limiter here, so it wasn't actually helping with the noise at all. What do you think about fixing the log rate-limiting instead?
I think the concern before was that downgrading this log message is almost like disabling it since it won't be included in any traces either.
Reviewable status:
complete! 0 of 0 LGTMs obtained
I think logging this message at any rate is completely pointless, since it is expected to occur 100% of the time when replication changes are ongoing. Could you give more details on why you think we should salvage this message at all? |
There was a problem hiding this comment.
Could you give more details on why you think we should salvage this message at all?
Yeah, that's fair. I can't think of any reason to.
Reviewable status:
|
bors r=aayushshah15 |
|
Build failed: |
This message wasn't useful, as it is always logged when a LEARNER upreplication is occurring. Nothing is lost by moving it behind `V(2)`. Release note: None
|
Oops, that was on me. Some tests actually assert on the trace, but the bors r=aayushshah15 |
|
Build succeeded: |
This message wasn't useful, as it is always logged when a LEARNER upreplication
is occurring. Nothing is lost by moving it behind
V(2).Release note: None