ui: update statement key on ui #80116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were displaying statement separated by the aggreation timestamp. Now that we don't show the aggregation timestamp column, we want to group all statements with same fingerprint id into a single row, no longer using the aggregation as part of a key. Aligning with the results we show for Statement Details page. Release note (ui change): Statements are not longer separated by aggregation interval on Statement Page. Now all statements with same fingerprint show as a single row.
|
This change is |
matthewtodd
approved these changes
Apr 18, 2022
complete! 1 of 0 LGTMs obtained
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were displaying statement separated
by the aggreation timestamp. Now that we don't show the
aggregation timestamp column, we want to group all
statements with same fingerprint id into a single row,
no longer using the aggregation as part of a key.
Aligning with the results we show for Statement Details
page.
Release note (ui change): Statements are not longer separated
by aggregation interval on Statement Page. Now all statements
with same fingerprint show as a single row.