kv/kvprober: use single batch in write probe #80007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adjusts `proberOpsImpl.Write` to issue its `Put`, `Del`, and `EndTxn` in a single `Batch`. This has a few positive effects: 1. it avoids writing intents 2. it requires a single pass through Raft 3. it avoids a pipeline stall after the Put goes through async consensus 4. it avoids async cleanup work after the txn commits It's not strictly necessary that we Put before we Del the key, because a Del is blind and leaves a tombstone even when the key is not live, but this is not guaranteed by the API, so we avoid depending on a subtlety of the implementation.
|
This change is |
joshimhoff
approved these changes
Apr 15, 2022
There was a problem hiding this comment.
Lovely! Can't wait to roll this out to prod and see a nice drop in fleet-wide kvprober write latency.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @tbg)
tbg
approved these changes
Apr 16, 2022
|
TFTRs! bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adjusts
proberOpsImpl.Writeto issue itsPut,Del, andEndTxnin a singleBatch. This has a few positive effects:It's not strictly necessary that we Put before we Del the key, because a
Del is blind and leaves a tombstone even when the key is not live, but
this is not guaranteed by the API, so we avoid depending on a subtlety
of the implementation.