Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: cli: disable client-side query cancellation for now #79740

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

knz
Copy link
Contributor

@knz knz commented Apr 10, 2022

Backport 1/1 commits from #79739.

/cc @cockroachdb/release

Release justification: prevent UX breakage for end-users


As discussed in issue #76483, there's a bug in lib/pq
which causes the session to be aborted on query cancellation.

The resulting UX is just too poor; if the session terminates, there's
no real benefit in keeping the shell alive. The user may as well stop
the shell and then restart it, which makes the situation clearer.

This commit thus disables cancellation support in the client
temporarily until we fix #76483.

As discussed in issue cockroachdb#76483, there's a bug in lib/pq
which causes the session to be aborted on query cancellation.

The resulting UX is just too poor; if the session terminates, there's
no real benefit in keeping the shell alive. The user may as well stop
the shell and then restart it, which makes the situation clearer.

This commit thus disables cancellation support in the client
temporarily until we fix cockroachdb#76483.

Release note (cli change): The mechanism for query cancellation
is disabled in the `sql` shell until a later patch release.
@knz knz requested a review from rafiss April 10, 2022 13:13
@knz knz requested a review from a team as a code owner April 10, 2022 13:13
@blathers-crl
Copy link

blathers-crl bot commented Apr 10, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz merged commit 95bbb08 into cockroachdb:release-22.1 Apr 13, 2022
@knz knz deleted the backport22.1-79739 branch April 13, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants