[DNM] add skeleton for passing soft slot granter to pebble #79556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for using additional theads for Pebble compaction compression and later for adjusting the number of concurrent compactions. Since these slots are not acquired or released in a very fine grained manner, we've chosen to model these in way that allows for over-commitment. The SoftSlotGranter should be used for acquiring and releasing such slots, instead of WorkQueue, since there is no queueing for such slots. Release note: None
Release note: None
|
This change is |
bananabrick
changed the title
bananabrick
changed the title
|
This doesn't have the Pebble level changes, so by itself, this pr doesn't make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.