release-22.1: backupccl: add deprecation notice for BACKUP TO and RESTORE FROM without subdir
#78250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
Informs: #78153 Release note (sql change): The `BACKUP TO` syntax to take backups is deprecated, and will be removed in a future release. Users are recommended to create a backup collection using the `BACKUP INTO` syntax in our docs.
Informs: #78153 Release note (sql change): The `RESTORE FROM` syntax without an explicit subdirectory pointing to a backup in a collection is deprecated, and will be removed in a future release. Users are recommended to use `RESTORE FROM <backup> IN <collection>` to restore a particular backup in a collection.
Informs: #78153 Release note: None
blathers-crl
bot
requested review from
a team and
dt
and removed request for
a team
blathers-crl
bot
force-pushed
the
blathers/backport-release-22.1-78165
branch
from
3d8d15f to
b5b1dd9
Compare
blathers-crl
bot
requested review from
adityamaru,
benbardin,
kathancox and
msbutler
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
blathers-crl
bot
added
blathers-backport
|
This change is |
msbutler
approved these changes
Mar 22, 2022
|
Bazel flake is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3/3 commits from #78165 on behalf of @adityamaru.
/cc @cockroachdb/release
backupccl: add deprecation notice for BACKUP TO
Informs: #78153
Release note (sql change): The
BACKUP TOsyntaxto take backups is deprecated, and will be removed in a future
release. Users are recommended to create a backup collection
using the
BACKUP INTOsyntax in our docs.backupccl: add deprecation notice to RESTORE FROM without subdir
Informs: #78153
Release note (sql change): The
RESTORE FROMsyntax without anexplicit subdirectory pointing to a backup in a collection is deprecated,
and will be removed in a future release.
Users are recommended to use
RESTORE FROM <backup> IN <collection>torestore a particular backup in a collection.
backupccl: add datadriven tests for deprecation notice
Informs: #78153
Release note: None
Release justification: Low risk, high benefit changes to existing functionality. Deprecation notice for BACKUP syntax that has been undocumented since 21.1.