Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: print old stack in SetPriorityID assertion #78166

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

tbg
Copy link
Member

@tbg tbg commented Mar 21, 2022

Closes #75939.

The issue appears to have been fixed; I've run 100ks of iterations
without a reproduction. Should it ever reproduce, the additional
stack trace should give valuable clues to debug the issue anew.

Release note: None

tbg added 2 commits March 21, 2022 10:49
This reverts commit 86f51ef.

Release note (<category, see below>): <what> <show> <why>
See cockroachdb#75939.

The issue appears to have been fixed; I've run 100ks of iterations
without a reproduction. Should it ever reproduce, the additional
stack trace should give valuable clues to debug the issue anew.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg tbg requested a review from a team March 21, 2022 12:53
@tbg tbg marked this pull request as ready for review March 21, 2022 12:53
@tbg tbg requested a review from a team as a code owner March 21, 2022 12:53
Copy link
Contributor

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the memory overhead here negligible?

@tbg
Copy link
Member Author

tbg commented Mar 22, 2022

Yes, there is one rangeIDQueue per store.

bors r=erikgrinaker

@craig
Copy link
Contributor

craig bot commented Mar 22, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

server: TestAdminAPITableStats failed [priority range ID already set]
3 participants