changefeedccl, kv: Add few metrics #77711
Conversation
|
This change is |
miretskiy
force-pushed
the
simple_metrics
branch
3 times, most recently
from
1b33c58 to
421f29b
Compare
miretskiy
force-pushed
the
simple_metrics
branch
2 times, most recently
from
796a3f8 to
f991596
Compare
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @erikgrinaker)
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:
pkg/ccl/changefeedccl/metrics.go, line 90 at r1 (raw file):
const sinkDoesNotCompress = -1 type recordEmittedMessagesCallback func(numMessages int, mvcc hlc.Timestamp, bytes int, compressedBytes int)
Can we get rid of this now, and only use recordOneMessageCallback?
pkg/ccl/changefeedccl/metrics.go, line 346 at r1 (raw file):
EmittedMessages: b.Counter(metaChangefeedEmittedMessages), MessageSize: b.Histogram(metaMessageSize, histogramWindow, 10<<20 /* 10MB max message size */, 1),
What happens for messages >10MB? Are they ignored, or do we have a bucket for those that exceed the limit?
pkg/kv/kvclient/kvcoord/dist_sender.go, line 143 at r3 (raw file):
} metaDistSenderRangefeedTotalRanges = metric.Metadata{ Name: "distsender.rangefeed.catchup_ranges",
This should be total_ranges.
pkg/kv/kvclient/kvcoord/dist_sender.go, line 146 at r3 (raw file):
Help: `Number of ranges executing rangefeed This counts the total number of rangefeed ranges.
nit: reword as "number of ranges with an active rangefeed" or something.
Add a histogram metric keeping track fo emitted messages sizes. Release Note (enterprise change): Changefeed records message size histogram. Release Justification: Low impact change.
miretskiy
force-pushed
the
simple_metrics
branch
from
f991596 to
724ac0f
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/ccl/changefeedccl/metrics.go, line 90 at r1 (raw file):
Previously, erikgrinaker (Erik Grinaker) wrote…
Can we get rid of this now, and only use
recordOneMessageCallback?
Nice. And it's gone.
pkg/ccl/changefeedccl/metrics.go, line 346 at r1 (raw file):
Previously, erikgrinaker (Erik Grinaker) wrote…
What happens for messages >10MB? Are they ignored, or do we have a bucket for those that exceed the limit?
Just a normal histogram nonsense -- these will be truncated; honestly, if your events are more than 10MB... it just a matter of how bad things are.. Cause they are bad.
pkg/kv/kvclient/kvcoord/dist_sender.go, line 143 at r3 (raw file):
Previously, erikgrinaker (Erik Grinaker) wrote…
This should be
total_ranges.
Nice. Thanks.
pkg/kv/kvclient/kvcoord/dist_sender.go, line 146 at r3 (raw file):
number of ranges with an active rangefeed
Done.
miretskiy
force-pushed
the
simple_metrics
branch
2 times, most recently
from
26d121a to
31d92f8
Compare
Add 2 metrics to keep track of the total number of ranges executing rangefeed, as well as the number of ranges currently performing the catchup scan. Release Notes: None Release Justification: Low impact, observability improvement.
miretskiy
force-pushed
the
simple_metrics
branch
from
31d92f8 to
934360b
Compare
There was a problem hiding this comment.
Reviewed 4 of 6 files at r1, 2 of 5 files at r4, 3 of 3 files at r5, all commit messages.
Reviewable status:
|
bors r+ |
|
Build succeeded: |
See commits for details.
Release Notes: None
Release justification: Low impact observability improvement