backupccl: add random data to tables in TestBackupRestoreDataRoundtrips #77602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jordanlewis
reviewed
Mar 15, 2022
msbutler
force-pushed
the
butler-rand-backup-restore
branch
from
2f3716a to
83d7af0
Compare
msbutler
force-pushed
the
butler-rand-backup-restore
branch
from
83d7af0 to
db08353
Compare
stevendanna
approved these changes
Jul 13, 2022
msbutler
force-pushed
the
butler-rand-backup-restore
branch
4 times, most recently
from
3849ccb to
7682ac0
Compare
Previously, TestBackupRestoreDataRoundtrips did not test if data in the randomly created tables were preserved after a backup restore roundtrip. This patch tries to add random data to each table and tests that the data is preserved across the roundtrip. In addition, this pr moves this test to its own package because the test takes a long time to run. Release note: None
msbutler
force-pushed
the
butler-rand-backup-restore
branch
from
7682ac0 to
a4a70f3
Compare
|
bors r=stevendanna |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, TestBackupRestoreDataRoundtrips did not test if data in the
randomly created tables were preserved after a backup restore roundtrip.
This patch tries to add random data to each table and tests that the data is
preserved across the roundtrip. In addition, this pr moves this test
to its own package because the test takes a long time to run.
Fixes #72345
Release justification: changes to test
Release note: None