-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: adjust ALTER TENANT ALL syntax #77519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained
1d56460
to
985005b
Compare
This change brings the syntax inline to what was proposed in the RFC. This is worthwhile since it matches with the syntax we use in other "ALL" cases -- notable `ALTER ROLE ALL SET ...``. Release justification: low risk update to new functionality Release note: None
985005b
to
048854d
Compare
seems like an unrelated flake bors r=knz,ajstorm |
error was
this is captured in #76448 |
Build succeeded: |
This change brings the syntax inline to what was proposed in the RFC.
This is worthwhile since it matches with the syntax we use in other
"ALL" cases -- notably `ALTER ROLE ALL SET ...``.
Release justification: low risk update to new functionality
Release note: None