Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: adjust ALTER TENANT ALL syntax #77519

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Mar 9, 2022

This change brings the syntax inline to what was proposed in the RFC.
This is worthwhile since it matches with the syntax we use in other
"ALL" cases -- notably `ALTER ROLE ALL SET ...``.

Release justification: low risk update to new functionality
Release note: None

@rafiss rafiss requested review from knz, ajstorm and a team March 9, 2022 04:14
@rafiss rafiss requested a review from a team as a code owner March 9, 2022 04:14
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks

Copy link
Collaborator

@ajstorm ajstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy! :lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@rafiss rafiss force-pushed the tenant-all-syntax branch from 1d56460 to 985005b Compare March 9, 2022 15:05
This change brings the syntax inline to what was proposed in the RFC.
This is worthwhile since it matches with the syntax we use in other
"ALL" cases -- notable `ALTER ROLE ALL SET ...``.

Release justification: low risk update to new functionality
Release note: None
@rafiss rafiss force-pushed the tenant-all-syntax branch from 985005b to 048854d Compare March 9, 2022 16:31
@rafiss
Copy link
Collaborator Author

rafiss commented Mar 9, 2022

seems like an unrelated flake

bors r=knz,ajstorm

@rafiss
Copy link
Collaborator Author

rafiss commented Mar 9, 2022

error was

[email protected]:26257/movr> \demo restart 3
node 3 has been restarted
[email protected]:26257/movr> select node_id, draining, decommissioning, membe �rship from crdb_internal.gossip_liveness ORDER BY node_id;
  node_id | draining | decommissioning | membership
----------+----------+-----------------+-------------
        1 |  false   |      false      | active
        2 |  false   |      false      | active
        3 |   true   |      false      | active
        4 |  false   |      false      | active
        5 |  false   |      false      | active
(5 rows)


Time: 1ms total (execution 1ms / network 0ms)

[email protected]:26257/movr> 
.220309 16:54:15.699234348 EXPECT TEST: TIMEOUT WAITING FOR "3 |  false   |      false      | active"
non-zero exit code: 1

this is captured in #76448

@craig
Copy link
Contributor

craig bot commented Mar 9, 2022

Build succeeded:

@craig craig bot merged commit 70a7826 into cockroachdb:master Mar 9, 2022
@rafiss rafiss deleted the tenant-all-syntax branch March 11, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants