Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: document usage of custom go runtime #77345

Merged
merged 1 commit into from
Mar 7, 2022
Merged

bazel: document usage of custom go runtime #77345

merged 1 commit into from
Mar 7, 2022

Conversation

irfansharif
Copy link
Contributor

Release justification: non-production code changes
Release note: None

@irfansharif
bazel: document usage of custom go runtime
9170df0 
Release justification: non-production code changes
Release note: None
@irfansharif irfansharif requested a review from rickystewart March 3, 2022 19:16
@cockroach-teamcity
Copy link
Member

This change is Reviewable

rickystewart
rickystewart approved these changes Mar 3, 2022
View reviewed changes
Copy link
Collaborator

@rickystewart rickystewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev generate bazel doesn't get rid of the extra (unused) arguments to load, right?

@irfansharif
Copy link
Contributor Author

Nope. TFTR! Onto the 8 hours bors merge phase of a comment-only PR.

bors+

@irfansharif
Copy link
Contributor Author

Huh, weird.

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 7, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 7, 2022

Build succeeded:

@craig craig bot merged commit 2867db0 into cockroachdb:master Mar 7, 2022
@irfansharif irfansharif deleted the 220303.doc-custom-go branch March 7, 2022 23:14
@irfansharif irfansharif mentioned this pull request Mar 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickystewart rickystewart rickystewart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irfansharif @cockroach-teamcity @rickystewart