loqrecovery: fix json field name in replica info file #77301
Conversation
|
This change is |
aliher1911
force-pushed
the
loq_recovery_fix_protoname
branch
from
96593e4 to
6384cd0
Compare
aliher1911
force-pushed
the
loq_recovery_fix_protoname
branch
from
6384cd0 to
9641854
Compare
|
Btw, why wasn't this picked up by any end-to-end tests? Do we lack sufficient coverage? |
|
It was picked up by the roachtest that is not merged yet. But we didn't have a specific test that manages to create a descriptor update for the TestCluster and recover from it. This seem to me like a "bug" in gogoproto or marshaller where marshalling to json generates data that can't be unmarshalled back. I don't think we should be trying to cover all the underlying libraries beside basics. |
aliher1911
force-pushed
the
loq_recovery_fix_protoname
branch
2 times, most recently
from
cb32996 to
75b55cb
Compare
Sure, but presumably this caused some functionality to break, which indicates gaps in our end-to-end testing. |
aliher1911
force-pushed
the
loq_recovery_fix_protoname
branch
2 times, most recently
from
c20ec33 to
92c93aa
Compare
Previously protobuf used camelcase name for repeated field for descriptor change. This was wrong as it was not parsed correctly by marshaller. This fix adds explicit name to proto specification to avoid default name generation. Release justification: This change is low risk as it fixes a bug in new functionality. Release note: None
aliher1911
force-pushed
the
loq_recovery_fix_protoname
branch
from
92c93aa to
ef9f4fb
Compare
|
bors r=erikgrinaker |
|
Build failed: |
|
bors r=erikgrinaker |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
76611: roachpb: add lock table metadata structures r=AlexTalks a=AlexTalks This change adds the protobuf structures, as well as the method, needed to capture the state of a replica's lock table. This is part of the work coming out of #75541, and is needed to be able to implement the `QueryLocks` RPC. Release note: None 77159: roachtest/tests: move prometheus client interface to separate package r=irfansharif a=ajwerner This way mockgen does not depend on the `roachtest/tests` package. Touches #76851. Release justification: non-production code change Release note: None 77301: loqrecovery: fix json field name in replica info file r=erikgrinaker a=aliher1911 Previously protobuf used camelcase name for repeated field for descriptor change. This was wrong as it was not parsed correctly by marshaller. This fix adds explicit name to proto specification to avoid default name generation. Release justification: This change is low risk as it fixes a bug in new functionality. Release note: None Fixes #77282 Co-authored-by: Alex Sarkesian <[email protected]> Co-authored-by: Andrew Werner <[email protected]> Co-authored-by: Oleg Afanasyev <[email protected]>
|
Build failed (retrying...): |
|
Build succeeded: |
Previously protobuf used camelcase name for repeated field
for descriptor change. This was wrong as it was not parsed
correctly by marshaller.
This fix adds explicit name to proto specification to avoid
default name generation.
Release justification: This change is low risk as it fixes
a bug in new functionality.
Release note: None
Fixes #77282