Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: make sure we inherit stdout and stderr when appropriate #77047

Merged
merged 1 commit into from
Feb 25, 2022
Merged

dev: make sure we inherit stdout and stderr when appropriate #77047

merged 1 commit into from
Feb 25, 2022

Conversation

rickystewart
Copy link
Collaborator

Otherwise bazel build/test output will be ugly (won't be colored/
use ncurses/etc.)

Release note: None

@rickystewart rickystewart requested a review from a team as a code owner February 25, 2022 17:48
@cockroach-teamcity
Copy link
Member

This change is Reviewable

postamar
postamar approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@postamar postamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot more sense this way: if the output is going to stdout or stderr we sure don't need to capture it in a buffer that just ends up spitting out its contents to that same stream down the road.

irfansharif
irfansharif approved these changes Feb 25, 2022
View reviewed changes
pkg/cmd/dev/io/exec/exec.go Outdated Show resolved Hide resolved
@rickystewart
dev: make sure we inherit stdout and stderr when appropriate
11e09c3 
Otherwise `bazel build`/`test` output will be ugly (won't be colored/
use `ncurses`/etc.)

Release note: None
@rickystewart
Copy link
Collaborator Author

bors r=postamar,irfansharif

@craig
Copy link
Contributor

craig bot commented Feb 25, 2022

Build succeeded:

@craig craig bot merged commit 2826900 into cockroachdb:master Feb 25, 2022
@tbg tbg mentioned this pull request Mar 24, 2022
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irfansharif irfansharif irfansharif approved these changes

@postamar postamar postamar approved these changes

@rail rail Awaiting requested review from rail

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickystewart @cockroach-teamcity @postamar @irfansharif