release: enable bincheck for tag pushes

[rail]

Previously, in order to run bincheck as part of the release process,
we would need to follow hands-on instructions at
https://github.com/cockroachdb/bincheck/blob/master/README.md.

This process requires some time and error prone.

This patch enables GitHub actions on tag push events and automates the
task.

Release note: None

[cockroach-teamcity]

This change is 

[rail]

https://github.com/rail/cockroach/actions/runs/1896886582 is an example run with hardcoded version and sha

[jlinder]

I like this as an incremental step to remove the manual run step. Looking forward to when we can run this as part of CI. In fact, we could do that now for the Linux binaries in TeamCity by making a new build config for running the linux one and make it depend on the output of the linux binary build config.

Maybe also put the bincheck directory under pkg/testutils?

Either way, LGTM.

[rail]

I like this as an incremental step to remove the manual run step. Looking forward to when we can run this as part of CI. In fact, we could do that now for the Linux binaries in TeamCity by making a new build config for running the linux one and make it depend on the output of the linux binary build config.

Yes! Let's make some baby steps first :)

Maybe also put the bincheck directory under pkg/testutils?

I thought about that too, but we have zero Go files here... 🤔

Either way, LGTM.

TFTR!

I'm thinking about backporting this too!

[celiala]

- reviewed at a high-level - everything makes sense to me.

Nice to see all the incremental improvements to the Week 1 tasks!

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @rail)

---

build/release/bincheck/buildroot.patch, line 2 at r1 (raw file):

diff --git a/package/ncurses/Config.in b/package/ncurses/Config.in
index 92be164..b3333f1 100644

did you mean to include this .patch file?

[rail]

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @celiala and @rail)

---

build/release/bincheck/buildroot.patch, line 2 at r1 (raw file):

Previously, celiala wrote…

did you mean to include this .patch file?

Yeah, we need it if we want to recreate the image.

[rail]

I have to merge this manually, bors cannot merge GitHub Actions files.

[rail]

blathers backport release-21.1 release-21.2

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from 763611f to blathers/backport-release-21.1-77038: POST https://api.github.com/repos/cockroachlabs/cockroach/merges: 403 Resource not accessible by integration []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch release-21.1 failed. See errors above.

---

error creating merge commit from 763611f to blathers/backport-release-21.2-77038: POST https://api.github.com/repos/cockroachlabs/cockroach/merges: 403 Resource not accessible by integration []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch release-21.2 failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}