sql: fix error handling for AOST clause #77025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
The AOST clause logix would previously error for any bounded staleness query that was used in a prepared statement. This is because prepared statements use an implicit txn, so the same AOST clause has to be checked multiple times in the txn. A recent commit refactored the error handling and caused this bug. Release note: None
rafiss
force-pushed
the
fix-bounded-staleness-test
branch
from
fbd9a41 to
7ab7829
Compare
RichardJCai
approved these changes
Feb 25, 2022
|
tftr! bors r=RichardJCai |
|
Build succeeded: |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #76979
fixes #76978
fixes #76977
fixes #76975
fixes #76787
The AOST clause logic would previously error for any bounded staleness
query that was used in a prepared statement. This is because prepared
statements use an implicit txn, so the same AOST clause has to be
checked multiple times in the txn. A recent commit refactored
the error handling and caused this bug.
Release note: None