sql: update tpcc and tpch stats #77019
Conversation
|
This change is |
There was a problem hiding this comment.
I wrote up the steps I followed in a new wiki page for posterity (thanks to @rytaft for the initial instructions), so you may be interested in reviewing that, too: https://cockroachlabs.atlassian.net/wiki/spaces/SQLQUERIES/pages/2448720032/Running+New+TPCC+and+TPCH+Stats
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @michae2 and @rytaft)
There was a problem hiding this comment.
Awesome! Thanks for writing this up.
Reviewed 25 of 25 files at r1, all commit messages.
Reviewable status:
pkg/sql/opt/memo/testdata/stats_quality/tpcc, line 1750 at r1 (raw file):
----Stats for consistency_12_merge_join_3---- WARNING: No previous statistics output was found. To collect actual statistics,
Looks like you need to run this one with -rewrite-actual-stats=true. No need to worry about possible regressions since this is a consistency check, not part of the main benchmark, but would still be good to update the stats.
There was a problem hiding this comment.
TFTR!
Reviewable status:
pkg/sql/opt/memo/testdata/stats_quality/tpcc, line 1750 at r1 (raw file):
Previously, rytaft (Rebecca Taft) wrote…
Looks like you need to run this one with
-rewrite-actual-stats=true. No need to worry about possible regressions since this is a consistency check, not part of the main benchmark, but would still be good to update the stats.
Thanks for catching this! Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
-- commits, line 12 at r2:
nit: don't forget to squash this one before you merge
This change rewrites the stats for tpcc and tpch to include the new table statistic avg_size. Fixes: cockroachdb#72332 Release note: None
rharding6373
force-pushed
the
stats_quality_testing
branch
from
7a622ba to
0048936
Compare
There was a problem hiding this comment.
Reviewable status:
Previously, rytaft (Rebecca Taft) wrote…
nit: don't forget to squash this one before you merge
Done.
|
bors r+ |
|
Build succeeded: |
This change rewrites the stats for tpcc and tpch to include the new
table statistic avg_size.
Fixes: #72332
Release note: None