sql, geo: Fix upper case geohash parsing and allow NULL arguments #76990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
approved these changes
Feb 24, 2022
pkg/geo/parse.go
Outdated
| @@ -239,6 +239,9 @@ func parseGeoHash(g string, precision int) (geohash.Box, error) { | |||
| return geohash.Box{}, pgerror.Newf(pgcode.InvalidParameterValue, "length of GeoHash must be greater than 0") | |||
| } | |||
|
|
|||
| // In PostGis, upper case letters are parsed as lower case letters. | |||
There was a problem hiding this comment.
(here and the test below)
nit: capitalise PostGIS as PostGIS
maybe use the term "case insensitive"
RichardJCai
force-pushed
the
fix_st_box2dfromgeohash
branch
from
39fd966 to
8c610ca
Compare
otan
approved these changes
Feb 25, 2022
pkg/geo/parse_test.go
Outdated
| @@ -642,6 +642,17 @@ func TestParseHash(t *testing.T) { | |||
| Max: -120.9375, | |||
| }, | |||
| }}, | |||
| // In PostGIS, upper case characters are parsed as lower case characters. | |||
There was a problem hiding this comment.
nit: use term "case sensitive"
There was a problem hiding this comment.
case-insensitive right? updated.
Release note (sql change): ST_Box2DFromGeoHash now accepts NULL arguments, the precision being NULL is the same as no precision being passed in at all. Upper case characters are now parsed as lower case characters for geohash, this matches Postgis behaviour.
RichardJCai
force-pushed
the
fix_st_box2dfromgeohash
branch
from
8c610ca to
537f89d
Compare
|
Thanks! |
|
Build succeeded: |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note (sql change): ST_Box2DFromGeoHash now accepts NULL arguments,
the precision being NULL is the same as no precision being passed in at all.
Upper case characters are now parsed as lower case characters for geohash,
this matches Postgis behaviour.
Resolves #75537