build: use TESTTIMEOUT in teamcity-test #76981
Conversation
We want to be able to adjust this easily, without a round-trip through CI. Inspired by [this run], where `test` hit the default 45m timeout. [this run]: https://teamcity.cockroachdb.com/viewLog.html?buildId=4448093&buildTypeId=Cockroach_UnitTests_Test&tab=buildResultsDiv Release note: None
|
This change is |
There was a problem hiding this comment.
Approving this but isn't setting build properties like this in the teamcity UI as opposed to in a source controlled file a release engineering anti-pattern?
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @tbg)
I'm not sure, that's for dev-inf to decide. TFTR! bors r=cucaroach |
Generally, we consider the best practice is to put as much configuration into the repo as possible. Some things can't be put in the repo (like code that switches between possible scripts in the repo depending on what is in the branch) and somethings we do not have infrastructure set up to put in the repo (like secrets). It can also be useful to allow engineers to override a configuration value set in the repo when manually starting a run. Following that guidance, it would be preferable to set this timeout value directly in the code and possibly provide an override via the TeamCity UI. Given this script is for running the unit tests with make and make will be going away soon, I don't think changing it here is important. |
|
Build succeeded: |
We want to be able to adjust this easily, without a round-trip through
CI.
Inspired by this run, where
testhit the default 45m timeout.Release note: None