kvserver: consider VOTER_INCOMING for lease transfer even if current … #76974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
aayushshah15
approved these changes
Feb 24, 2022
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @shralex and @tbg)
pkg/kv/kvserver/allocator.go, line 2034 at r1 (raw file):
// excludeReplicasInNeedOfSnapshots filters out the `replicas` that may be in // need of a raft snapshot. If this function is called with the `raftStatus` of // a non-raft leader replica, an empty slice is returned.
Let's also update this comment with the caveat that VOTER_INCOMINGs are always included in the result. Likewise for the comment above replicaMayNeedSnapshot.
…leaseholder isn't the Raft leader This was previously done as part of cockroachdb#74077 but a check for leader-leaseholder collocation was missed by that patch. This check is removed in this PR, as this case is already covered by replicaMayNeedSnapshot. In future PRs, we will make the error returned by maybeTransferLeaseDuringLeaveJoint retriable by AdminSplit. Release note: None
shralex
force-pushed
the
update_expected_relocate_errors2
branch
from
96535cf to
cd98815
Compare
|
bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
This was referenced Feb 26, 2022
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…leaseholder isn't the Raft leader
This was previously done as part of #74077
but a check for leader-leaseholder collocation was missed by that patch. This check is removed
in this PR, as this case is already covered by replicaMayNeedSnapshot.
With this PR, restoreTPCCInc/nodes=10 passed 85 times in a row.
In future PRs, we will make the error returned by maybeTransferLeaseDuringLeaveJoint retriable by
AdminSplit.
Release note: None