Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: a couple tweaks to bazel CI #76958

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Conversation

rickystewart
Copy link
Collaborator

  • Run go mod tidy in Bazel CI.
  • When running unit tests, write the profile file to /artifacts so it
    can be inspected later if necessary.

Release note: None

@rickystewart rickystewart requested a review from rail February 23, 2022 23:58
@rickystewart rickystewart requested a review from a team as a code owner February 23, 2022 23:58
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rickystewart)


build/teamcity/cockroach/ci/tests/unit_tests_impl.sh, line 8 at r1 (raw file):

$(bazel info bazel-bin --config=ci)/pkg/cmd/bazci/bazci_/bazci --config=ci \
		                   test //pkg:small_tests //pkg:medium_tests //pkg:large_tests //pkg:enormous_tests -- \
                                   --profile=/artifacts/profile.gz

🎉 Great idea!

* Run `go mod tidy` in Bazel CI.
* When running unit tests, write the profile file to `/artifacts` so it
  can be inspected later if necessary.

Release note: None
@rickystewart
Copy link
Collaborator Author

bors r=rail

@rickystewart
Copy link
Collaborator Author

bors r=rail

@craig
Copy link
Contributor

craig bot commented Feb 25, 2022

Build succeeded:

@craig craig bot merged commit c3ff362 into cockroachdb:master Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants