Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

genbzl: hoist bindata sources #76956

Merged
merged 2 commits into from
Feb 24, 2022
Merged

genbzl: hoist bindata sources #76956

merged 2 commits into from
Feb 24, 2022

Conversation

rickystewart
Copy link
Collaborator

Release note: None

@rickystewart
bazel: refine dev generate bazel skip optimization
2a09abb 
Without this stuff, a `dev generate bazel` without
`COCKROACH_BAZEL_FORCE_GENERATE=1` resulted in skipping `genbzl`
incorrectly.

Closes cockroachdb#76905.

Release note: None
@rickystewart
genbzl: hoist bindata sources
bbb568b 
Release note: None
@rickystewart rickystewart requested a review from a team as a code owner February 23, 2022 23:34
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart
Copy link
Collaborator Author

Ignore the first commit, it's from #76955.

@rickystewart
Copy link
Collaborator Author

bors r=irfansharif

@craig
Copy link
Contributor

craig bot commented Feb 24, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 24, 2022

Build failed:

@irfansharif
Copy link
Contributor

Unrelated flakes.

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 24, 2022

Build succeeded:

@craig craig bot merged commit 920464f into cockroachdb:master Feb 24, 2022
@tbg tbg mentioned this pull request Mar 24, 2022
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irfansharif irfansharif irfansharif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickystewart @cockroach-teamcity @irfansharif