Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv/kvserver: skip TestReplicaCircuitBreaker_Follower_QuorumLoss #76894

Conversation

tbg
Copy link
Member

@tbg tbg commented Feb 22, 2022

Refs: #76781

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None

Refs: cockroachdb#76781

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None
@tbg tbg requested a review from sumeerbhola February 22, 2022 18:12
@tbg tbg requested a review from a team as a code owner February 22, 2022 18:12
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg
Copy link
Member Author

tbg commented Feb 22, 2022

Can whoever stamps this bors it? I'm likely going to be offline until tomorrow.

@erikgrinaker
Copy link
Contributor

Yup, will do.

@tbg
Copy link
Member Author

tbg commented Feb 23, 2022

bors r+

@erikgrinaker
Copy link
Contributor

Sorry, had lots of stuff going on last night and totally forgot about this.

@craig
Copy link
Contributor

craig bot commented Feb 23, 2022

Build failed:

@tbg
Copy link
Member Author

tbg commented Feb 24, 2022

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 24, 2022

Build failed:

@tbg
Copy link
Member Author

tbg commented Feb 24, 2022

bors r+
bors single on

@craig
Copy link
Contributor

craig bot commented Feb 24, 2022

Build failed:

@tbg
Copy link
Member Author

tbg commented Feb 24, 2022

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 24, 2022

Build failed:

@tbg
Copy link
Member Author

tbg commented Feb 24, 2022

bors r+

It's getting comical

@postamar
Copy link
Contributor

To be honest it saddens me that skipping tests requires bors to re-run the full CI suite. There should be a way to override this when doing things like skipping tests.

@craig
Copy link
Contributor

craig bot commented Feb 24, 2022

Build failed:

@tbg
Copy link
Member Author

tbg commented Feb 24, 2022

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 24, 2022

Build succeeded:

@craig craig bot merged commit 50c5a92 into cockroachdb:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants