kvserver: consistency checker cleanups, pt 1 #76841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Purely mechanical. Release note: None
|
This change is |
erikgrinaker
approved these changes
Feb 21, 2022
Adding a comment while I'm there. Release note: None
Release note: None
Release note: None
|
bors r=erikgrinaker |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thinking through our recent problems with pile-up of sha512 computations again,
I would like to touch up this code somewhat to give the "waiter" the option to
cancel the inflight computation when it gives up waiting. I realized a bit of
preliminary clean-up was in order before I do that. There might be more
clean-up after this PR.
Release note: None