ui:increase timeout for statements api call #76739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the timeout for statement api was 1 minute, which was causing timeout error messages when the user selected long time periods containing a lot of data. This commit increases the timeout and adds a message when the Statement and Transactions pages are loading, indicating it could take a few minutes to load. This commit also fixes the position for the error message when the user still hits the error. Release note (ui change): Add long loading messages to SQL Activity pages.
|
This change is |
Annebirzin
approved these changes
Feb 23, 2022
complete! 0 of 0 LGTMs obtained
jocrl
approved these changes
Feb 23, 2022
|
bors r+ |
|
Build succeeded: |
|
blathers backport 21.2 |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 34e2d7d to blathers/backport-release-21.2-76739: POST https://api.github.com/repos/cockroachlabs/cockroach/merges: 403 Resource not accessible by integration [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
maryliag
added a commit
to maryliag/cockroach
that referenced
this pull request
Mar 22, 2022
Follow up from cockroachdb#76739 Add timeout to fetchData function and increase the timeout value for the Statement calls for usage on CC Console. Release note: None
maryliag
added a commit
to maryliag/cockroach
that referenced
this pull request
Mar 23, 2022
Follow up from cockroachdb#76739 Add timeout to fetchData function and increase the timeout value for the Statement calls for usage on CC Console. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Mar 23, 2022
…78277 #78294 #78313 77513: sql: remove schema and non-bundle formats from import table help text r=rhu713 a=rhu713 Creating a schema inside the IMPORT TABLE statement is no longer supported, update the help text to reflect this. Also remove non-bundle formats from the formats accepted by IMPORT TABLE as they do not contain schema. Release justification: update help text to reflect functionality Release note: None 77707: kvaccessor: implement server-side pagination r=irfansharif a=irfansharif Fixes #77505. The KVAccessor did not previously paginate -- it was possible then for large requests (think initial reconciliation with a large number of descriptors) to generate write batches that could exceed max raft command size limits. The KVAccessor is also backed by a system table. In order to function, it dynamically constructed SQL statements proportional in size to the size of the request. That too was slightly worrisome -- large enough requests could maybe result in server-side OOMs. This commit introduces server-side pagination to mitigate both risks. Release justification: low risk, high benefit changes Release note: None 78045: server: VIEWACTIVITY role gates unredacted nodes info r=dhartunian a=dhartunian Previously, the `Nodes` and `NodesUI` endpoints were gated behind the Admin role. For the former endpoint requests would fail if the user didn't have the Admin role, and for the latter, we'd show partially redacted information that omitted hostnames and IP addresses. This was deemed problematic for customers who did not want to set the Admin role just to grant a user the ability to view detailed node information about the cluster. This PR changes the role gate for the endpoints above to use the `VIEWACTIVITY` role option. Users with the option will be able to access the `Nodes` endpoint and see unredacted nodes information at the `NodesUI` endpoint used by the DB Console. As a result, the nodes overview page as well as the node reports page will now show unredacted information to users with `VIEWACTIVITY`. (Existing functionality for Admins us also retained as those users implicitly have the `VIEWACTIVITY` role.) Resolves #77665 Release note (ui change, security update, api change): The `_status/nodes` endpoint is avaible to all users with the `VIEWACTIVITY` role option, not just Admins. In the DB Console, the Nodes Overview and Node Reports pages will now display unredacted information containing node hostnames and IP addresses for all users with the `VIEWACTIVITY` role option. Previously this was also gated for Admins only. 78063: ccl/multitenantccl: add kv ru metric r=kvoli a=kvoli Previously, tenant consumption metrics included total request units and it's dis-aggregated components. This patch adds `tenant.consumption.kv_request_units` tracking the portion of `tenant.consumption.request_units` attributable to kv. Release justification: None Release note: None 78087: sql: apply zone configs to temp indexes during backfill r=rhu713 a=rhu713 Previously applying a zone config to a new index that's backfilling only applied the config to the new index, and not the corresponding temporary index created for the backfill. Change this so that the temporary indexes also get the same zone configs as the new index. Release justification: fixes temp indexes not getting zone configs Release note: None 78103: roachtest: increase sysbench workload concurrency r=nvanbenschoten a=nvanbenschoten This commit increases the workload concurrency we use in sysbench from 4 threads per vCPU per node to 8 threads per vCPU per node. This increases top-line throughput across all workloads, meaning that they had room to grow. We saw this in experimentation in #78102 and also in https://mariadb.com/ja/resources/blog/mariadb-xpand-crunches-cockroach-with-sysbench/. 78142: changefeedccl: Release descriptors when running core changefeed. r=miretskiy a=miretskiy Release descriptor leases acquired during core style changefeed planning. Failure to do so blocks schema changes. Release Notes (enterprise change): Do not block schema changes when executing core style change feeds. Fixes [#76927](#76927) Release Justification: low danger stability fix. 78182: ui: remove LineGraphOld r=xinhaoz,dhartunian a=Azhng Resolves #76177 This commit removes LineGraphOld component from the codebase. LineGraphOld component has been replaced by the new LineGraph component introduced in #63087. Release note: None 78265: vendor: bump Pebble to 6164579cf2cb r=jbowens a=nicktrav ``` 6164579c cache: use finalizer for freeing manually allocated memory 0ad18689 compaction: disentangle compaction rangedels from InternalIterator 2c7b5358 ci: build and test against Go version 1.18 02418522 internal/metamorphic: add range key iteration 70ff2a37 internal/rangekey: seek exhausted iters when switching directions 7a946186 db: avoid levelIter invariant violation on exhausted mergingIter 10191d70 db: move range keys from memtable to global arena atomically a7cff657 db: fix determinism of limited reverse iteration with range keys 4ad1b577 *: Skip over files with no point keys in point key levelIter e19101fb sstable: re-pool datablock buffers in the sstable Writer f9d4a33d docs: minor tweaks to table format version RFC 910ce605 sstable: use a single level index in block property data driven test 56c5aebe internal/manifest: encode/decode range keys in manifest 11305409 internal/rangekey: refactor Coalescer into a pure function Coalesce fb5fdde8 db: fix TestSplitUserKeyMigration flake 9f45cc9a db: mock event duration directly in tests b1410e80 internal/lint: add a lint check to enforce crlfmt 9d3e2fc9 *: apply crlfmt 4dc50ecd internal/manifest: additional range key test cases for order checks ``` Release note: None. 78277: authors: Add mari to AUTHORS r=rickystewart a=programmablereya Release note: None 78294: api: increase timeout of statements request for CC Console r=maryliag a=maryliag Follow up from #76739 Add timeout to fetchData function and increase the timeout value for the Statement calls for usage on CC Console. Release note: None 78313: kvserver: deflake TestGossipHandlesReplacedNode r=erikgrinaker a=tbg Fixes #74447. Release note: None Co-authored-by: Rui Hu <[email protected]> Co-authored-by: irfan sharif <[email protected]> Co-authored-by: David Hartunian <[email protected]> Co-authored-by: Austen McClernon <[email protected]> Co-authored-by: Nathan VanBenschoten <[email protected]> Co-authored-by: Yevgeniy Miretskiy <[email protected]> Co-authored-by: Azhng <[email protected]> Co-authored-by: Nick Travers <[email protected]> Co-authored-by: Mari Staib <[email protected]> Co-authored-by: Marylia Gutierrez <[email protected]> Co-authored-by: Tobias Grieger <[email protected]>
blathers-crl bot
pushed a commit
that referenced
this pull request
Mar 23, 2022
Follow up from #76739 Add timeout to fetchData function and increase the timeout value for the Statement calls for usage on CC Console. Release note: None
maryliag
added a commit
to maryliag/cockroach
that referenced
this pull request
Mar 23, 2022
Follow up from cockroachdb#76739 Add timeout to fetchData function and increase the timeout value for the Statement calls for usage on CC Console. Release note: None
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the timeout for statement api was 1 minute,
which was causing timeout error messages when the user
selected long time periods containing a lot of data.
This commit increases the timeout to 30min and adds a message
when the Statement and Transactions pages are loading,
indicating it could take a few minutes to load.
This commit also fixes the position for the error message
when the user still hits the error.
New messages on Statements and Transactions page
Error message before
after
Release note (ui change): Add long loading messages to SQL Activity
pages.