Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1.55: DNM: release: release-infra-related testing #76718

Closed

Conversation

celiala
Copy link
Collaborator

@celiala celiala commented Feb 17, 2022

Backport 1/1 commits from #46732.

DO-NOT-MERGE! This is testing to see if backport works
with a release-MM.d.p type branch.

/cc @cockroachdb/release


release-20.1 is cut.

Release note: None

Jira issue: CRDB-14812

DO-NOT-MERGE! This is testing to see if backport works
with a `release-MM.d.p` type branch.

Release note: None
@celiala celiala added the do-not-merge bors won't merge a PR with this label. label Feb 17, 2022
@blathers-crl
Copy link

blathers-crl bot commented Feb 17, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@celiala celiala changed the title release-2.1.55: build: disable required release justifications release-2.1.55: DNM: release: release-infra-related testing Feb 28, 2022
@celiala celiala closed this Apr 5, 2022
@celiala celiala deleted the backport2.1.55-46732 branch April 5, 2022 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge bors won't merge a PR with this label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants