Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: sql: stale descriptor state could be observed in crdb_internal tables #76520

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

fqazi
Copy link
Collaborator

@fqazi fqazi commented Feb 14, 2022

Backport 1/1 commits from #76381.

fixes #70008
Release justification: low risk and this issue can lead to incorrect results for customers querying information via crdb_internal tables.

/cc @cockroachdb/release


Fixes: #75825

Previously, when an uncommitted descriptor was added
to a descriptor collection, we would not reset the cache of
all immutable descriptors (used by some crdb_internal functions).
This was inadequate because this could result in
incorrect results from crdb_internal tables which returned
information related to constraints, columns. To address this,
this patch will reset the descriptor cache for all
fetched descriptors when an uncommitted descriptor is
added into the collection.

Release note (bug fix): Certain crdb_internal tables could return incorrect
information due to cached table descriptor information.

@fqazi fqazi requested a review from a team February 14, 2022 17:39
@blathers-crl
Copy link

blathers-crl bot commented Feb 14, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ajwerner
Copy link
Contributor

I think this deserves a release note. Otherwise, LGTM

Fixes: cockroachdb#75825

Previously, when an uncommitted descriptor was added
to a descriptor collection, we would not reset the cache of
all immutable descriptors (used by some crdb_internal functions).
This was inadequate because this could result in
incorrect results from crdb_internal tables which returned
information related to constraints, columns. To address this,
this patch will reset the descriptor cache for all
fetched descriptors when an uncommitted descriptor is
added into the collection.

Release note (bug fix): Certain crdb_internal tables could return incorrect
information due to cached table descriptor information.
@fqazi fqazi force-pushed the backport21.2-76381 branch from eccf94b to 747d8e1 Compare February 14, 2022 17:57
@fqazi fqazi merged commit 22ddacc into cockroachdb:release-21.2 Feb 16, 2022
@fqazi
Copy link
Collaborator Author

fqazi commented Feb 16, 2022

@rafiss TFTR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants