Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

descmetadata: remove bogus target in BUILD.bazel #76489

Merged

Conversation

ajwerner
Copy link
Contributor

This can break ... builds.

Release note: None

This can break `...` builds.

Release note: None
@ajwerner ajwerner requested a review from a team February 14, 2022 04:23
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)

@ajwerner
Copy link
Contributor Author

bors r+

craig bot pushed a commit that referenced this pull request Feb 14, 2022
76489: descmetadata: remove bogus target in BUILD.bazel r=ajwerner a=ajwerner

This can break `...` builds.

Release note: None

Co-authored-by: Andrew Werner <[email protected]>
@craig
Copy link
Contributor

craig bot commented Feb 14, 2022

Build failed:

@ajwerner
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 14, 2022

Build failed:

@ajwerner
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 14, 2022

Build succeeded:

@craig craig bot merged commit 66dfdac into cockroachdb:master Feb 14, 2022
@rickystewart
Copy link
Collaborator

#74261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants