Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: disable metamorphic constants when calling execgen #76309

Merged
merged 1 commit into from
Feb 10, 2022
Merged

build: disable metamorphic constants when calling execgen #76309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1650,7 +1650,7 @@ pkg/util/log/log_channels_generated.go: pkg/util/log/gen/main.go pkg/util/log/lo
.PHONY: execgen
execgen: ## Regenerate generated code for the vectorized execution engine.
execgen: $(EXECGEN_TARGETS) bin/execgen
for i in $(EXECGEN_TARGETS); do echo EXECGEN $$i && ./bin/execgen -fmt=false $$i > $$i; done
for i in $(EXECGEN_TARGETS); do echo EXECGEN $$i && COCKROACH_INTERNAL_DISABLE_METAMORPHIC_TESTING=true ./bin/execgen -fmt=false $$i > $$i; done
goimports -w $(EXECGEN_TARGETS)

# Add a catch-all rule for any non-existent execgen generated
Expand Down
1 change: 1 addition & 0 deletions pkg/sql/colexecop/EXECGEN.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ def gen_eg_go_rules(targets):
# [2]: https://docs.bazel.build/versions/3.7.0/be/general.html#general-advice
# [3]: https://github.com/cockroachdb/cockroach/pull/57027
cmd = """
export COCKROACH_INTERNAL_DISABLE_METAMORPHIC_TESTING=true
ln -s external/cockroach/pkg pkg
$(location :execgen) -template $(SRCS) \
-fmt=false pkg/sql/colexec/$@ > $@
Expand Down