server: add internal_app_name_prefix to ListSessionsResponse

[gtr]

Previously, the InternalAppNamePrefix constant from catconstants was
only included in the Statements Response. This change adds that same
field to the ListSessionsResponse.

Release note (API change): InternalAppNamePrefix added to ListSessionsResponse.

[cockroach-teamcity]

This change is 

[xinhaoz]

---

pkg/server/serverpb/status.proto, line 823 at r1 (raw file):

  // If set and non-empty, indicates the prefix to application_name
  // used for statements/queries issued internally by CockroachDB.
  string internal_app_name_prefix = 4;

Any reason this field value is 4 and not 3?

[gtr]

pkg/server/serverpb/status.proto, line 823 at r1 (raw file):

  // If set and non-empty, indicates the prefix to application_name
  // used for statements/queries issued internally by CockroachDB.
  string internal_app_name_prefix = 4;

Any reason this field value is 4 and not 3?

Good catch! Fixed it.

[maryliag]

Reviewed 1 of 2 files at r2.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @gtr and @xinhaoz)

---

-- commits, line 8 at r2:
you're adding a new value on the api, so there is a release note, in this case a "api change" one

[xinhaoz]

---

pkg/server/status.go, line 2298 at r3 (raw file):

		Sessions:              make([]serverpb.Session, 0),
		Errors:                make([]serverpb.ListSessionsError, 0),
		InternalAppNamePrefix: catconstants.InternalAppNamePrefix,

Make sure to add this toListSessions response for tenants too (in tenant_status.go).

[xinhaoz]

Reviewed 1 of 1 files at r3.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @gtr, @maryliag, and @xinhaoz)

[gtr]

bors r+

[craig]

Build succeeded:

• GitHub CI (Cockroach)