Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: handle null values in merge_{statement,transaction}_stats builtins #75760

Merged

Conversation

xinhaoz
Copy link
Member

@xinhaoz xinhaoz commented Jan 31, 2022

Fixes #75607

The merge_{statement,transaction}_stats builtin functions should skip
NULL JSONB values.

Release note: None

Fixes cockroachdb#75607

The merge_{statement,transaction}_stats builtin functions should skip
NULL JSONB values.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@xinhaoz xinhaoz requested a review from a team January 31, 2022 22:37
Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)

@xinhaoz
Copy link
Member Author

xinhaoz commented Jan 31, 2022

TFTR!
bors r+

@craig
Copy link
Contributor

craig bot commented Feb 1, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 1, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 1, 2022

Build succeeded:

@craig craig bot merged commit 2e5cbeb into cockroachdb:master Feb 1, 2022
@xinhaoz xinhaoz deleted the handle-nulls-in-merge-stats-builtins branch February 1, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlsmith: expected *DJSON, found tree.dNull
3 participants