-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: add array of JSON type to pre-constructed types #75550
Conversation
nice, thanks! I think this might fix the error that came up here #74078 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after fixing nits
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rafiss and @xinhaoz)
-- commits, line 4 at r1:
nit: typo in preconstructed
docs/generated/sql/functions.md, line 328 at r1 (raw file):
<tr><td><a name="crdb_internal.merge_statement_stats"></a><code>crdb_internal.merge_statement_stats(input: jsonb[]) → jsonb</code></td><td><span class="funcdesc"><p>Merge an array of roachpb.StatementStatistics into a single JSONB object</p> </span></td></tr> <tr><td><a name="crdb_internal.merge_transaction_stats"></a><code>crdb_internal.merge_transaction_stats(input: anyelement[]) → jsonb</code></td><td><span class="funcdesc"><p>Merge an array of roachpb.TransactionStatistics into a single JSONB object</p>
i think you need to run make buildshort
to update these auto generated docs
This commit adds the JSONArray type to the preconstructed list of types for use in bultin function definition. Release note: None
8da7d19
to
61a1ba0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @xinhaoz)
LGTM :)
TFTR! |
Build succeeded: |
This commit adds the JSONArray type to the preconstructed list of types
for use in bultin function definition.
Release note: None