sql: disable span-config on flakey 5node tests #75281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
cucaroach
force-pushed
the
deflake-5node
branch
from
82a23e3 to
af7ceb9
Compare
miretskiy
approved these changes
Jan 21, 2022
| @@ -1,4 +1,5 @@ | |||
| # LogicTest: 5node-default-configs !5node-metadata | |||
| # cluster-opt: disable-span-configs | |||
There was a problem hiding this comment.
Do we want to file an issue so that this can be removed when fixed?
cucaroach
force-pushed
the
deflake-5node
branch
from
af7ceb9 to
8271929
Compare
Temporary fix for cockroachdb#72802 Due to cockroachdb#73876 these tests have become flakey. With the disable-span-configs option 70 runs of make stress on the opt logic tests pass. Release note: None
cucaroach
force-pushed
the
deflake-5node
branch
from
8271929 to
422e00e
Compare
|
bors r+ |
|
Build failed (retrying...): |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
irfansharif
added a commit
to irfansharif/cockroach
that referenced
this pull request
Jan 24, 2022
We opted this test out of using the span configs infra in cockroachdb#75281 after observing a CI flake. Following the analysis in the last commit, it may have been due to stale distsender caches affecting the physical plan generated. This fix is speculative because I was unable to repro the original flake under stress. Attempt (successful after 1000s of runs on GCE worker over 20+ minutes): dev test pkg/sql/logictest \ -f 'TestLogic/^5node-disk$/distsql_enum' \ --show-logs -v --stress --stress-args '-p 4' -- --test_arg -show-sql Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix for #72802 and 5node/distsql_enum CI failures.
Due to #73876 these tests have become flakey.
With the disable-span-configs option 70 runs of make stress on the opt logic tests pass.
Release note: None