sql: fix logic to detect if primary index constraint name is in use #75155
Conversation
|
This change is |
fqazi
changed the title
|
Looking into some CI stuff this isn't quiet right. |
fqazi
force-pushed
the
constraintErr
branch
2 times, most recently
from
29459ea to
e608026
Compare
fqazi
changed the title
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @fqazi and @postamar)
pkg/sql/logictest/testdata/logic_test/alter_table, line 2120 at r1 (raw file):
create table const_tbl (a int, b int, constraint "bob" primary key (a, b)); alter table const_tbl drop constraint "bob"; alter table const_tbl add constraint "bob" primary key (a, b); -- this statement
Can you do this multiple times in the same transaction to exercise that case too?
Code quote:
alter table const_tbl add constraint "bob" primary key (a, b); -- this statement
161ad2e to
52713c6
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/sql/logictest/testdata/logic_test/alter_table, line 2120 at r1 (raw file):
Previously, ajwerner wrote…
Can you do this multiple times in the same transaction to exercise that case too?
Added a test to cover that case.
There was a problem hiding this comment.
Reviewed 1 of 2 files at r2.
Reviewable status:
pkg/sql/logictest/testdata/logic_test/alter_table, line 2188 at r2 (raw file):
COMMIT; statement error relation \"const_tbl\" \(150\): unimplemented: primary key dropped without subsequent addition of new primary key in same transaction.*
replace the number here with \d+?
Fixes: cockroachdb#75154 Previously, when dropping and adding a primary constraint inside a transaction with the same name would fail since we would detect a primary index with the same name was active. This was inadequate because replacing an index within a transaction is supported, even if the name is the same. To address this, this patch checks if the index is marked for deletion via the disabled flag, in which case the name is can be safely used (the index with the original name is dropped). Release note (bug fix): Dropping and creating a primary index constraint with the same name in a transaction would incorrectly fail.
|
bors r+ |
|
Build succeeded: |
Fixes: #75154
Previously, when dropping and adding a primary constraint inside
a transaction with the same name would fail since we would detect
a primary index with the same name was active. This was inadequate
because replacing an index within a transaction is supported, even
if the name is the same. To address this, this patch checks if
the index is marked for deletion via the disabled flag, in which
case the name is not currently in use because the index will be
dropped in the transaction.
Release note (bug fix): Dropping and creating a primary index constraint in the same transaction with the same name would incorrectly fail.