sql: default index recommendations to be off for logic tests #74154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This commit refactors `pkg/sql/vars.go` to use globalFalse and globalTrue as the setting GlobalDefault where possible. Release note: None
nehageorge
force-pushed
the
disable-index-tests
branch
from
71907e3 to
6ad9b01
Compare
Previously, we did not have a cluster setting for index recommendations. We add one in this commit in order to configure index recommendations to be off for logic tests. This is to avoid flaky tests, as the index recommendation output can vary depending on the best plan chosen by the optimizer. However, this cluster setting is temporary and will be migrated to `ALTER ROLE ALL` for 22.1 (along with other `sql.defaults` cluster settings). Fixes: cockroachdb#74069. Release note: None
nehageorge
force-pushed
the
disable-index-tests
branch
from
6ad9b01 to
ecba509
Compare
mgartner
approved these changes
Dec 21, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 48 of 48 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nehageorge)
|
Closing this in favour of #74159. We want to avoid adding new cluster settings as we add the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql: refactor GlobalDefault for session variables
This commit refactors
pkg/sql/vars.goto use globalFalse andglobalTrue as the setting GlobalDefault where possible.
Release note: None
sql: default index recommendations to be off for logic tests
Previously, we did not have a cluster setting for index recommendations.
We add one in this commit in order to configure index recommendations to
be off for logic tests. This is to avoid flaky tests, as the index
recommendation output can vary depending on the best plan chosen by the
optimizer.
However, this cluster setting is temporary and will be migrated to
ALTER ROLE ALLfor 22.1 (along with othersql.defaultscluster settings).Fixes: #74069.
Release note: None