roachtest: make crdb crash on span-use-after-Finish #73941
Conversation
|
This change is |
|
Can you run a manual nightly with this change first? We'll want to avoid a wave of nightly failures blanketing the various teams. Also, the commit seems to be doing various things besides setting the env var the commit message mentions, mind either splitting up the commits + updating the PR message to describe all changes, or removing the stuff that doesn't apply to this commit? |
andreimatei
force-pushed
the
tracing.use-after-finish-roachtest
branch
from
7f34b48 to
84ff073
Compare
Release note: None
This patch makes roachtest pass an env var to crdb asking it to panic on mis-use of tracing spans. I've been battling such bugs, which become more problematic as I'm trying to introduce span reuse. In production we'll probably continue tolerating such bugs for the time being, but I want tests to yell. Unit tests are already running with this use-after-Finish detection, and so far so good. I've done a manual run of all the roachtests in this configuration and nothing crashed, so I don't expect a tragedy. Release note: None
andreimatei
force-pushed
the
tracing.use-after-finish-roachtest
branch
from
84ff073 to
d38e4a6
Compare
There was a problem hiding this comment.
Can you run a manual nightly with this change first? We'll want to avoid a wave of nightly failures blanketing the various teams.
I did (mentioned in the commit msg).
Also, the commit seems to be doing various things besides setting the env var the commit message mentions
Like what? The only thing that makes sense to split is adding a comment to COCKROACH_ENABLE_RPC_COMPRESSION. I split that one.
Perhaps you're referring to copy the flag defaults from roachprod to roachtest - but that's directly related to the wanting to pass one more env variable.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @tbg)
Oops, sorry.
Ah, I understand now. Thanks! LGTM |
There was a problem hiding this comment.
TFTR!
Did another run of all the roachtests, came out clean.
bors r+
Reviewable status:
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
This patch makes roachtest pass an env var to crdb asking it to panic on
mis-use of tracing spans. I've been battling such bugs, which become
more problematic as I'm trying to introduce span reuse. In production
we'll probably continue tolerating such bugs for the time being, but I
want tests to yell. Unit tests are already running with this
use-after-Finish detection, and so far so good. I've done a manual run
of all the roachtests in this configuration and nothing crashed, so I
don't expect a tragedy.
Release note: None