bazel: perform staticcheck checks in nogo
#73572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rickystewart
force-pushed
the
nogo_staticcheck
branch
7 times, most recently
from
bf94a51 to
e6665c2
Compare
rickystewart
force-pushed
the
nogo_staticcheck
branch
from
e6665c2 to
95ec124
Compare
rail
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
Reviewed 3 of 252 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rail)
Add a new binary `generate-staticcheck`, part of `dev generate bazel`, that creates a package in `build/bazelutil/staticcheckanalyzers` capturing a single `staticcheck` check. Then we capture the list of analyzers in `build/bazelutil/staticcheckanalyzers/def.bzl` and add all those checks to `nogo`. However, we can't directly use the `Analyzer`s provided by the upstream library, because they report *all* violations regardless of `lint:ignore` directives. In order to address this we add a helper library at `pkg/testutils/lint/passes/staticcheck` that munges the `Analyzer`s to additionally pull the `lint:ignore` directives and ignore any reported diagnostics that correspond to a `lint:ignore`. This follows the example set by https://github.com/sluongng/staticcheck-codegen, but we don't directly use that code, since we need to inject our own stuff and we want to make sure the content here is pinned to the right version of `staticcheck`. We run the `staticcheck` and `simple` [checks](https://staticcheck.io/docs/checks). `stylecheck` is still broken: cockroachdb#73568 Closes cockroachdb#68496. Release note: None
rickystewart
force-pushed
the
nogo_staticcheck
branch
from
95ec124 to
33ef0ff
Compare
|
bors r=rail |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new binary
generate-staticcheck, part ofdev generate bazel,that creates a package in
build/bazelutil/staticcheckanalyzerscapturing a single
staticcheckcheck. Then we capture the list ofanalyzers in
build/bazelutil/staticcheckanalyzers/def.bzland add allthose checks to
nogo.However, we can't directly use the
Analyzers provided by the upstreamlibrary, because they report all violations regardless of
lint:ignoredirectives. In order to address this we add a helperlibrary at
pkg/testutils/lint/passes/staticcheckthat munges theAnalyzers to additionally pull thelint:ignoredirectives and ignoreany reported diagnostics that correspond to a
lint:ignore.This follows the example set by https://github.com/sluongng/staticcheck-codegen,
but we don't directly use that code, since we need to inject our own
stuff and we want to make sure the content here is pinned to the right
version of
staticcheck.We run the
staticcheckandsimplechecks.stylecheckis still broken: #73568Closes #68496.
Release note: None