roachprod: introduce Node type #72957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
There is a lot of confusion in the code around node "indexes". Sometimes these are a (0-based) index in the target list of nodes, sometimes they are a (1-based) node ID. This makes the code harder to follow and more error-prone (in fact, there are a couple of places where we convert from one to the other incorrectly). This change introduces the types `Node` and `Nodes` and switches code to use `Node` (rather than the 0-based index) whenever possible. This enlists the compiler's help, as it is no longer legal to implicitly convert from one to the other. Release note: None
rail
approved these changes
Nov 19, 2021
There was a problem hiding this comment.
Love it! So much easier to read when you don't need to figure out what int means in a particular context. There is a small typo, after fixing which this can be merged.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @healthy-pod and @RaduBerinde)
pkg/roachprod/install/nodes.go, line 26 at r1 (raw file):
type Node int // Node is a list of nodes. In most cases, this is a set and the values are
Typo: s/Node/Nodes/
RaduBerinde
force-pushed
the
roachprod-advertise-addr
branch
from
86a1f31 to
e482fc8
Compare
RaduBerinde
commented
Nov 19, 2021
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
pkg/roachprod/install/nodes.go, line 26 at r1 (raw file):
Previously, rail (Rail Aliiev) wrote…
Typo: s/Node/Nodes/
Done.
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lot of confusion in the code around node "indexes".
Sometimes these are a (0-based) index in the target list of nodes,
sometimes they are a (1-based) node ID. This makes the code harder to
follow and more error-prone (in fact, there are a couple of places
where we convert from one to the other incorrectly).
This change introduces the types
NodeandNodesand switches codeto use
Node(rather than the 0-based index) whenever possible. Thisenlists the compiler's help, as it is no longer legal to implicitly
convert from one to the other.
Release note: None