Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-20.2: sql: fix FK check bug in ALTER COLUMN TYPE #71167

Merged
merged 1 commit into from
Oct 26, 2021
Merged

release-20.2: sql: fix FK check bug in ALTER COLUMN TYPE #71167

merged 1 commit into from
Oct 26, 2021

Conversation

postamar
Copy link

@postamar postamar commented Oct 5, 2021 •
edited
Loading

Backport 1/1 commits from #71097.

/cc @cockroachdb/release

This commit fixes an implementation bug when checking that the table's
foreign keys didn't hold a reference to the altered column.

Fixes #71089.

Release justification: simple fix for blatant correctness bug

Release note (bug fix): fixes a bug which caused ALTER COLUMN TYPE
statements to fail when they shouldn't have.

@blathers-crl
Copy link

blathers-crl bot commented Oct 5, 2021 •
edited by postamar
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@postamar postamar requested a review from RichardJCai October 5, 2021 19:15
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@postamar postamar requested a review from a team October 5, 2021 19:15
RichardJCai
RichardJCai approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@RichardJCai RichardJCai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, re-running CI

ajwerner
ajwerner approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @postamar)

@postamar postamar force-pushed the backport20.2-71097 branch 2 times, most recently from 2a97bc1 to f4376db Compare October 14, 2021 16:56
sql: fix FK check bug in ALTER COLUMN TYPE
d05034e 
This commit fixes an implementation bug when checking that the table's
foreign keys didn't hold a reference to the altered column.

Fixes cockroachdb#71089.

Release justification: simple fix for blatant correctness bug

Release note (bug fix): fixes a bug which caused ALTER COLUMN TYPE
statements to fail when they shouldn't have.
@postamar postamar merged commit 43fbea9 into cockroachdb:release-20.2 Oct 26, 2021
@postamar postamar deleted the backport20.2-71097 branch October 26, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajwerner ajwerner ajwerner approved these changes

@RichardJCai RichardJCai RichardJCai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@postamar @cockroach-teamcity @ajwerner @RichardJCai