Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/tracing: remove DeprecatedInternalStructured #71057

Conversation

andreimatei
Copy link
Contributor

This recording field was necessary for compatibility with 21.1. Now that
21.2 is out, we no longer need it, and it costs allocations.

Release note: None

@andreimatei andreimatei requested a review from adityamaru October 3, 2021 23:08
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andreimatei andreimatei force-pushed the tracing.remove-DeprecatedInternalStructured branch from c6fc4a2 to 74400c2 Compare October 4, 2021 14:06
Copy link
Contributor Author

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

@craig
Copy link
Contributor

craig bot commented Oct 4, 2021

Build failed:

This recording field was necessary for compatibility with 21.1. Now that
21.2 is out, we no longer need it, and it costs allocations.

Release note: None
@andreimatei andreimatei force-pushed the tracing.remove-DeprecatedInternalStructured branch from 74400c2 to 0e20ab8 Compare October 4, 2021 15:43
Copy link
Contributor Author

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

@craig
Copy link
Contributor

craig bot commented Oct 4, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Oct 5, 2021

Build succeeded:

@craig craig bot merged commit 99a0138 into cockroachdb:master Oct 5, 2021
@andreimatei andreimatei deleted the tracing.remove-DeprecatedInternalStructured branch January 22, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants