roachprod: upgrade Azure Ubuntu image to 20.04 #70944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @rail)
pkg/cmd/roachprod/vm/azure/azure.go, line 517 at r1 (raw file):
}, StorageProfile: &compute.StorageProfile{ // You can find available versions by running the following command:
Guess you also get the info from https://discourse.ubuntu.com/t/find-ubuntu-images-on-microsoft-azure/18918, you may want to add this into the comment part for readers to reference.
Previously, currently used Ubuntu 18.04 doesn't support `systemd-run --same-dir`, which is used by some roachprod scripts. Additionally, GCE and AWS already use Ubuntu 20.04 based images for roachprod. Updating the base image to Ubuntu 20.04 fixes the issue above and aligns the version with other cloud providers. Release note: None
rail
force-pushed
the
azure-ubuntu-20.04
branch
from
b46d2a1 to
9bf0789
Compare
jlinder
approved these changes
Oct 5, 2021
|
bors r=jlinder |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, currently used Ubuntu 18.04 doesn't support
systemd-run --same-dir, which is used by some roachprod scripts. Additionally, GCEand AWS already use Ubuntu 20.04 based images for roachprod.
Updating the base image to Ubuntu 20.04 fixes the issue above and aligns
the version with other cloud providers.
Release note: None