backupccl: drop temp system database on failed restore #70380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityamaru
requested review from
dt,
msbutler and
a team
and removed request for
a team
|
This change is |
adityamaru
force-pushed
the
drop-system-on-failed-restore
branch
from
363f2ff to
5191571
Compare
Previously, if a restore failed during execution we would not cleanup the temproary system db descriptor that we create during a cluster restore. A `SHOW DATABASES` after the failed restore would show the `crdb_temp_system` database as well. This change adds logic to drop the database in the OnFailOrCancel hook of the retore job. Fixes: cockroachdb#70324 Release note: None
adityamaru
force-pushed
the
drop-system-on-failed-restore
branch
from
5191571 to
2b4c072
Compare
dt
approved these changes
Sep 21, 2021
|
TFTR! bors r=dt |
|
🔒 Permission denied Existing reviewers: click here to make adityamaru a reviewer |
|
Sorry to see you go Aditya, good luck on your next gig! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a restore failed during execution
we would not cleanup the temproary system db descriptor
that we create during a cluster restore. A
SHOW DATABASESafter the failed restore would showthe
crdb_temp_systemdatabase as well.This change adds logic to drop the database in the
OnFailOrCancel hook of the retore job.
Fixes: #70324
Release note: None