clusterversion: remove Start21_1 (no longer applicable) #70268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cockroachdb#65200. The last remaining 21.1 version (V21_1) can be removed as part of cockroachdb#69828. Release note: None
|
This change is |
ajwerner
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @celiala and @postamar)
|
bors r+ |
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Oct 22, 2021
71632: sql: make sure pgwire bind always happens in a transaction r=otan a=rafiss fixes #70378 and maybe #64140 The approach of using a transaction matches what we do for pgwire Parse messages already. This is important to make sure that user-defined types are leased correctly. This also updated the SQL EXECUTE command to resolve user-defined types so that it gets the latest changes. Release note (bug fix): Adding new values to a user-defined enum type will previously would cause a prepared statement using that type to not work. This now works as expected. 71836: clusterversion: introduce 22.1 development versions r=celiala a=celiala Fix: #69828 Looking at past Version values for `Start{XX_X}`, I think the `Version` value for `Key: Start22_1` should instead be `Major: 21, Minor: 2, ...`. Start21_1 (from #70268): ``` // v21.1 versions. Internal versions defined here-on-forth must be even. { Key: Start21_1, Version: roachpb.Version{Major: 20, Minor: 2, Internal: 2}, }, ``` Start 21_2: ``` { Key: Start21_2, Version: roachpb.Version{Major: 21, Minor: 1, Internal: 1102}, }, ``` Release justification: Non-production code change. Release note: None 71856: bazel: skip recompilation when using dev+bazel r=irfansharif a=irfansharif Fixes #71835. When switching between using `dev` and `bazel` raw, I kept seeing our C++ protobuf dependency getting recompiled (slowly). It appears that the bazel build for protobuf has a dependency on $PATH (see bazelbuild/intellij#1169 and bazelbuild/bazel#7095). Specifying [`--incompatible_strict_action_env`](https://docs.bazel.build/versions/main/command-line-reference.html#flag--incompatible_strict_action_env) pins PATH and avoids the build cache thrashing we were seeing before. Release note: None Co-authored-by: Rafi Shamim <[email protected]> Co-authored-by: Celia La <[email protected]> Co-authored-by: irfan sharif <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65200. The last remaining 21.1 version (V21_1) can be removed as
part of #69828.
Release note: None