roachtest: update sqlalchemy roachtest to use SQLA 1.4 #66153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was failing because we reorganized the project and bumped the SQL Alchemy supported version to 1.4.17. Fixes cockroachdb#66075 Release note: None
|
This change is |
rafiss
approved these changes
Jun 8, 2021
| @@ -22,7 +22,7 @@ import ( | |||
| var sqlAlchemyResultRegex = regexp.MustCompile(`^(?P<test>test.*::.*::[^ \[\]]*(?:\[.*])?) (?P<result>\w+)\s+\[.+]$`) | |||
| var sqlAlchemyReleaseTagRegex = regexp.MustCompile(`^rel_(?P<major>\d+)_(?P<minor>\d+)_(?P<point>\d+)$`) | |||
|
|
|||
| var supportedSQLAlchemyTag = "rel_1_3_24" | |||
| var supportedSQLAlchemyTag = "rel_1_4_17" | |||
There was a problem hiding this comment.
nice -- should we also pin the version of sqlalchemy-cockroachdb under test in this script?
There was a problem hiding this comment.
Talked offline, we'll keep it at master for now and monitor how things go with Gord's work on the adapter.
|
TFTR! bors r=rafiss |
|
Build failed (retrying...): |
This was referenced Jun 8, 2021
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was failing because we reorganized the project and bumped the
SQL Alchemy supported version to 1.4.17.
Fixes #66075
Release note: None