storage: fix "inverted range" panic #6143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed 6 of 6 files at r1. kv/dist_sender_server_test.go, line 673 [r1] (raw file): roachpb/metadata.go, line 130 [r1] (raw file): Comments from Reviewable |
The store now returns NotLeaderError instead of a malformed RangeKeyMismatchError when a request is addressed to an uninitialized replica. The replica that caused the creation of the uninitialized replica is used as our best guess for the current leader. Guard against regressions by checking the validity of the descriptor passed to NewRangeKeyMismatchError. Also add an admittedly complex regression test. Fixes cockroachdb#6027
bdarnell
force-pushed
the
inverted-range
branch
from
ea97f13 to
1511367
Compare
|
I don't see how #6144 would make sense in the commit message. That issue would be an alternative (and more general) solution, but it's a future work item and so the proper place for it is an issue. |
|
I just wanted #6144 linked to this PR (and vice versa), but mentioning it here was actually all required for that, so fine by me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The store now returns NotLeaderError instead of a malformed
RangeKeyMismatchError when a request is addressed to an uninitialized
replica. The replica that caused the creation of the uninitialized
replica is used as our best guess for the current leader.
Guard against regressions by checking the validity of the descriptor
passed to NewRangeKeyMismatchError. Also add an admittedly complex
regression test.
Fixes #6027
This change is